Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1343 - re-enable std.concurrency integration #1345

Merged
merged 6 commits into from
Jan 29, 2016
Merged

Fix #1343 - re-enable std.concurrency integration #1345

merged 6 commits into from
Jan 29, 2016

Conversation

s-ludwig
Copy link
Member

@s-ludwig s-ludwig commented Dec 2, 2015

No description provided.

@Geod24
Copy link
Contributor

Geod24 commented Dec 2, 2015

Moving from d8b51c2

I've reverted the changes and will start a branch. I didn't realize that the dependencies had become so deep in the meantime.

Had the same experience a few weeks ago. Also, one question is, are we absolutely certain that the scheduler will be set first ? What if the user doesn't import any vibe.d module from his main (he could use extern functions, and have the implementation in other modules. Would the shared ctor still run first ?

@s-ludwig
Copy link
Member Author

s-ludwig commented Dec 3, 2015

That should be the case, since the module constructor would still be in the dependency chain. Not sure if dynamic libraries work correctly, but since the initialization happens in vibe.core.core, otherwise this would not only break the std.concurrency integration, but all vibe.d core functionality.

@s-ludwig
(Re-)enable std.concurrency integration on >=2.067.
36baef1
@s-ludwig
Keep using vibe.d's std.concurrency implementation internally.
0ffc05f 
There are some unsupported features in std.concurrency that makes it impossible to use for some current use cases:
- Non-copyable objects cannot be passed to spawned threads
- Tasks started with runTask and runWorkerTask cannot be used as message receivers
@s-ludwig
Fix RedisSubscriberImpl to use vibe.d's own message passing implement…
806f8c0 
…ation.
@s-ludwig
Fix compilation of libev and libasync drivers.
905583d
@s-ludwig
Add workaround for libasync test assertion failure.
29f85d1 
std.concurrency caused a driver instance to be created in a libasync control thread.
@s-ludwig
Copy link
Member Author

I just went over the source again and all existing places use vibe.d's own "...Compat" version of the message passing code, so there should be no functional change there. Since the tests are green now, including the message passing tests, I'll merge this now and tag a new pre-release for 0.7.27.

s-ludwig added a commit that referenced this pull request Jan 29, 2016
@s-ludwig
Merge pull request #1345 from rejectedsoftware/fix_1343
8257198 
Fix #1343 - re-enable std.concurrency integration
@s-ludwig s-ludwig merged commit 8257198 into master Jan 29, 2016
@s-ludwig s-ludwig deleted the fix_1343 branch January 29, 2016 16:14
@yannick yannick mentioned this pull request Jan 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-ludwig @Geod24