Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement plain text starting with < in Diet templates. #1007

Merged
merged 1 commit into from
Mar 10, 2015

Conversation

redstar
Copy link
Contributor

@redstar redstar commented Mar 9, 2015

This is the Jade way to emit conditional comments but works
with all plain text starting with <, too.

See http://jade-lang.com/reference/comments/.

@s-ludwig
Copy link
Member

s-ludwig commented Mar 9, 2015

Hm, interesting, did they remove the //if syntax? I'm pretty sure that it came from Jade when I implemented it. Anyway, supporting this shouldn't hurt! Can you add a short unit test around line 1455 to ensure that this stays functional?

This is the Jade way to emit conditional comments but works
with all plain text starting with <, too.

See http://jade-lang.com/reference/comments/.
@redstar
Copy link
Contributor Author

redstar commented Mar 9, 2015

Sure!

@redstar
Copy link
Contributor Author

redstar commented Mar 9, 2015

According to the Jade changelog, version 1.0.0 removed support for conditional comments.

@s-ludwig
Copy link
Member

Okay, thanks! Definitely makes sense to try and stay compatible with the 1.0.0 spec.

s-ludwig added a commit that referenced this pull request Mar 10, 2015
Implement plain text starting with < in Diet templates.
@s-ludwig s-ludwig merged commit 46e8d01 into vibe-d:master Mar 10, 2015
@redstar redstar deleted the plaintext branch March 11, 2015 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants