Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set serial driver in json format #788

Open
Lefuneste83 opened this issue Sep 10, 2024 · 1 comment
Open

Unable to set serial driver in json format #788

Lefuneste83 opened this issue Sep 10, 2024 · 1 comment

Comments

@Lefuneste83
Copy link

Lefuneste83 commented Sep 10, 2024

While undergoing some keyboard definition cleanup for a PR on main QMK repo, I have noticed one annoying issue while testing in parallel against vial-qmk codebase.

Using KLOR keyboard on RP2040 ARM MCU

QMK code reviewers ask me to migrate all definitions under json format. While transposing these changes in vial-qmk I notice that one specific and significant setting seems to be lagging behind in the vial-qmk codebase.

I have managed to get rid of all rules.mk entries at keyboard level except for one. I am unable to implement the serial driver to json format.

Rules.mk entry that should be transposable to json:

SERIAL_DRIVER = vendor

Equivalent expected json entry:

    "split": {
        "serial": {
            "driver": "vendor",
            "pin": "GP1"
        },

When implementing this change I get the following error in compilation pre validation
☒ split: Additional properties are not allowed ('serial' was unexpected)

This setting is required as we are moving to a full duplex serial communication between the two keyboard sides and the legacy and outdated soft_serial_pin is not sufficient anymore from the json data structure. A code update on this specific part would be much appreciated.

Thanks!

@OWL4C
Copy link

OWL4C commented Oct 18, 2024

I have the same error on a RP2040 board with the default qmk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants