Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about egnn #11

Open
Byun-jinyoung opened this issue Jul 11, 2022 · 0 comments
Open

Some questions about egnn #11

Byun-jinyoung opened this issue Jul 11, 2022 · 0 comments

Comments

@Byun-jinyoung
Copy link

Hi,

I wonder about the implementation of two parts in the egnn codes.

First, in E_GCL code,

    def forward(self, h, edge_index, coord, edge_attr=None, node_attr=None):
        row, col = edge_index
        radial, coord_diff = self.coord2radial(edge_index, coord)

        edge_feat = self.edge_model(h[row], h[col], radial, edge_attr)
        coord     = self.coord_model(coord, edge_index, coord_diff, edge_feat)
        h, agg    = self.node_model(h, edge_index, edge_feat, node_attr)
        # coord = self.node_coord_model(h, coord)                                                                                
        # x = self.node_model(x, edge_index, x[col], u, batch)  # GCN                                                            
        return h, coord, edge_attr

the edge_feat is not return of forward method and the edge_attr, which is input of forward, is just returned.
Can I use the edge_feat as the one of the returns of forward method?

Second, Can I predict the h, edge_attr with the EGNN Autoencoder?
In example main_ae.py code, the decoder simply consists of linear transformation and just predicts adjacency matrix.
What I want to do is to predict the h_x (node attribute) and edge attribute. So did I just use the output of autoencoder as same way of adjacency matrix?

Best regards,
Jinyoung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant