Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio Project Files #8

Open
GoogleCodeExporter opened this issue Mar 13, 2015 · 8 comments
Open

Visual Studio Project Files #8

GoogleCodeExporter opened this issue Mar 13, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Open project
2. Build

What is the expected output? What do you see instead?
I expect it to compile. Can not find Rlog.lib. It generates Rlog.dll but
nothing else.

What version of the product are you using? On what operating system?
1.4 on Windows XP.

Original issue reported on code.google.com by [email protected] on 23 Jul 2008 at 8:14

@GoogleCodeExporter
Copy link
Author

Hmm.  This appears to be due to the RLOG_DECL being (incorrectly)
defined as empty.  Thus, no symbols are being exported, so no .lib
file is generated.

I'm the guy that submitted the VS8 build files, but it seems like
something got left out.  I'll see if I can work up a quick patch to
fix it...

Original comment by [email protected] on 11 Aug 2008 at 8:43

@GoogleCodeExporter
Copy link
Author

Okay, I'm attaching a patch that fixes things for me on Windows.
Since a lot of Windows users don't deal much with patches, I better
explain how to apply it.

First, you need a copy of the 'patch' utility that'll run on
Windows.  Cygwin/Msys users probably have this covered already, but
if that means nothing to you, probably the easiest thing to do is
grab the zip from here:

  - http://gnuwin32.sourceforge.net/downlinks/patch-bin-zip.php

You only need the file from it called 'patch.exe'. You can just
extract it to the same folder as your 'rlog-1.4' sources.  Save the
attached patch to the same location.

Open a command window in the same directory where 'patch.exe', the
'rlog-1.4' folder and 'rlog-1.4_win32.patch' are all located and
type the following:

  patch -p0 < rlog-1.4_win32.patch

If all goes well, it should emit output similar to this:

  patching file rlog-1.4\rlog\rlog.h
  patching file rlog-1.4\rlog\RLogTime.cpp
  patching file rlog-1.4\rlog\RLogTime.h
  patching file rlog-1.4/win32/common.h.msvc80
  patching file rlog-1.4\win32\rlog.vcproj

You should now be able to launch Visual Studio 2005, open rlog.sln,
and build the solution.  (Note: it emits a lot of warnings, but it
should build successfully.  Please post here if it doesn't.)

There's one final quirk worth mentioning.  The file
rlog-1.4\win32\rlog.sln has UNIX-style line endings, which causes
Visual Studio not to open it correctly.  You can fix this easily
enough by changing the line endings.

I use ':set ff=dos' in Vim to do this, but whatever method you
choose should work.  Try using something like
http://www.iconv.com/unix2dos.htm if you have no idea. (NOTE: This
isn't a problem when opening rlog.sln from within Visual Studio;
it's only when trying to double-click the file that it doesn't
launch correctly.)

Hopefully Valient will be able to incorporate this patch into a
release candidate snapshot soon and things will 'just work' on
Windows.  Until then, the steps above should get you going...

HTH,

- Dave Wolfe
  Royal Oak, Michigan

Original comment by [email protected] on 11 Aug 2008 at 11:15

Attachments:

@GoogleCodeExporter
Copy link
Author

thank you sir; it works now.

Original comment by [email protected] on 12 Aug 2008 at 3:38

@GoogleCodeExporter
Copy link
Author

I thought it best to update this issue, rather than create a new one.

I've been working with rlog for a while on Ubuntu and it works amazingly well! 
I've
just tried to recompile my app on Windows (eugh..) and MS VC++ Express 2008 but
unfortunately rlog fails to compile. MSVC now has its own vsnprintf but also, 
when I
did manage to get rlog to compile I got linker errors despite linking to the
generated .lib file. 

Any chance we could get updated MSVC support?

Original comment by [email protected] on 1 Sep 2009 at 8:47

@GoogleCodeExporter
Copy link
Author

I don't have any MSVC build environment.  Patches welcome.

Original comment by valient on 28 Nov 2009 at 7:31

  • Added labels: OpSys-Windows

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Hi,

Just for reference, I am able to build and use rlog for windows using Microsoft 
Visual Studio 2008 Professional running on Windows XP 32 bit by doing the 
following:

1. Download rlog 1.4 from http://code.google.com/p/rlog/
2. Extract the code, but do not open in VS yet
3. Apply the patch kindly supplied by Dave Wolfe above. Note that I had no need 
to convert line endings.
4. Open the solution file in VS2008 and allow it to update it.
5. We now need to manually patch common.h (as VS2008 already defines 
vsnprintf), so open rlog-1.4\rlog\common.h and comment out line 71 (#   define 
vsnprintf _vsnprintf). Rather than commenting out, I'm sure there #ifdefs you 
could use to take this action only for certain version of VS.
6. Build in VS2008 should now work, and the .lib and .dll files are produced.

Original comment by [email protected] on 26 Nov 2012 at 10:32

@GoogleCodeExporter
Copy link
Author

Hi.  I just applied this patch.  However, the compile error under VS 2008 in 
common.h cannot be fixed by commenting out line 71 of that file, because the VS 
project will regenerate that file every time and put the original line back in. 
 Instead, edit the file "common.h.msvc80", and look for the line  "#   define 
vsnprintf _vsnprintf"
Comment THAT out, and then rebuild.  This will recreate common.h the right way, 
and it then built for me. 

Original comment by [email protected] on 22 Nov 2013 at 6:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant