-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cooked input cancellation on Windows #63
Comments
Started a discussion: microsoft/terminal#12143 |
Proposed a whacky but potentially workable(?) hack for this here: microsoft/terminal#12143 (comment) Thoughts on that approach very welcome. (cc @scottbilas @xoofx) |
I'm always in favor of an approach that works, even with caveats, over endless waiting for the gears to turn in a big software company. :) Seems like it's hard to get their attention on this. |
One aspect to consider is how this would work when standard I/O handles are redirected. Obviously, if we close redirected handles, we can't just simply reopen them again like we can with the console. We would need to special-case files, pipes, etc. 🤔 Looking at the .NET BCL, there's a whole bunch of code to handle cancellation in the |
Sigh. Doesn't seem like that hack will work either.
I guess this might have worked on Windows 7, but Windows 8.1 completely changed how console handles work, so I figure that's why I had no luck here. Sadness all around. |
Need to see if |
Ok, good news: It seems to work. (See the discussion on microsoft/terminal#12143 for context.) If you can, please either clone the Git repo and try the |
Going to reopen because of this: microsoft/terminal#12143 (comment) Still, we support cancellation of raw input now, so that's a lot better than nothing. This issue will track cancellation support for cooked input now. |
See discussion on #46 and #61, as well as commit adf2a45.
The text was updated successfully, but these errors were encountered: