Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RockyLinux 8/9 support #326

Merged
merged 4 commits into from
Mar 18, 2024
Merged

RockyLinux 8/9 support #326

merged 4 commits into from
Mar 18, 2024

Conversation

0x00ace
Copy link
Contributor

@0x00ace 0x00ace commented Mar 17, 2024

Added support for RockyLinux 8/9

I have successfully created images using commands:

magnum-cluster-api-image-builder \
  --operating-system rockylinux-8 \
  --version v1.27.11 \
  --image-builder-version v0.1.25
magnum-cluster-api-image-builder \
  --operating-system rockylinux-9 \
  --version v1.27.11 \
  --image-builder-version v0.1.25

And I have successfully booted Kubernetes clusters using these images

/build-new-images

@mnaser
Copy link
Member

mnaser commented Mar 17, 2024

Thank you for your contribution! This is great, seems like the failure is unrelated. I am working on a few improvements in #327 so we can actually do a few things:

  • Test this code to build images
  • Run RockyLinux built images through CI
  • Test bumping the image-builder version globally so it works out of the box

@mnaser
Copy link
Member

mnaser commented Mar 18, 2024

I think we're probably good to land this, since you made a PR from your own fork, Jenkins won't take this into place. I'll merge and see how it goes.

@mnaser mnaser merged commit 2a53f3e into vexxhost:main Mar 18, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants