Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop unexpected rollouts #324

Merged
merged 1 commit into from
Mar 17, 2024
Merged

fix: stop unexpected rollouts #324

merged 1 commit into from
Mar 17, 2024

Conversation

mnaser
Copy link
Member

@mnaser mnaser commented Mar 15, 2024

When making any node group changes, we were previously
making an entire change of all the cluster resources. With
this change, we're instead simply making the small changes
in the node group which should avoid unexpected full rollouts
of node groups when changing min/max for autoscaling or
resizing a cluster.

@mnaser mnaser force-pushed the stop-rollouts branch 7 times, most recently from 2be5e28 to e4bab1b Compare March 16, 2024 02:20
@okozachenko1203
Copy link
Member

okozachenko1203 commented Mar 16, 2024

As long as the coe cluster upgrade with the same coe clustertemplate is supported, I think there is no downside in the approach that will trigger capi clusterclass update only when coe cluster upgrade requested.
If coe cluster upgrade requires a different coe clustertemplate from the current one, users have to create a twin coe cluster template for clusterclass update. If so, we will have more coe clustertemplates, and will end up with having the same number of coe clsutertemplates as the number of coe clusters in the worst case even though we delete the old coe clustertemplates which no coe cluster refers to.
But fortunately, magnum api allows cluster upgrade with the current coe clustertemplate like heat does with --existing flag.
So we can do capi clusterclass update without k8s version change or even without any changes on openstack coe cluster resource in this way.

@mnaser
Copy link
Member Author

mnaser commented Mar 16, 2024

Nice, I didn't know that @okozachenko1203 so this is the best of both worlds.

I will also try and document this a little bit deeper as well in the documentation as well.

When making any node group changes, we were previously
making an entire change of all the cluster resources.  With
this change, we're instead simply making the small changes
in the node group which should avoid unexpected full rollouts
of node groups when changing min/max for autoscaling or
resizing a cluster.

Signed-off-by: Mohammed Naser <[email protected]>
@mnaser mnaser merged commit 78f8a02 into main Mar 17, 2024
10 of 11 checks passed
@mnaser mnaser deleted the stop-rollouts branch March 17, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants