Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement faster ECDH operation so encryption of offers takes less time #1258

Open
leomira opened this issue Aug 26, 2024 · 1 comment
Open

Comments

@leomira
Copy link

leomira commented Aug 26, 2024

No description provided.

@leomira leomira converted this from a draft issue Aug 26, 2024
@kaladivo
Copy link
Collaborator

kaladivo commented Sep 16, 2024

We are using this library: https://github.com/margelo/react-native-quick-crypto/tree/main

Here is the list of implementation coverage: https://github.com/margelo/react-native-quick-crypto/blob/0.x/docs/implementation-coverage.md

Our app uses ECIES encryption to encrypt offers. Currently our biggest bottleneck when encrypting offers is generating ECDH shared secret.

Meaning that we need the following methods to be implemented:
❌ ecdh.computeSecret(otherPublicKey[, inputEncoding][, outputEncoding])
❌ ecdh.generateKeys([encoding[, format]])
❌ ecdh.getPrivateKey([encoding])
❌ ecdh.getPublicKey([encoding][, format])
❌ ecdh.setPrivateKey(privateKey[, encoding])

Curves that need to be supported: secp224r1 (P-224) and secp256k1 (P-256K).

Also the implementation of ECDH is already done in Node: https://github.com/nodejs/node/blob/main/src/crypto/crypto_dh.cc

Also, there are tests inside the app and in TS: https://github.com/vexl-it/vexl-next/blob/main/packages/cryptography/src/operations/eciesLegacy.test.ts

@kaladivo kaladivo self-assigned this Oct 29, 2024
@leomira leomira closed this as completed Nov 15, 2024
@github-project-automation github-project-automation bot moved this from In early access for Champions to Shipped in Development Kanban Nov 15, 2024
@kaladivo kaladivo changed the title Specify faster crypto requirements Implement faster ECDH operation so encryption of offers takes less time Dec 2, 2024
@kaladivo kaladivo removed their assignment Dec 2, 2024
@kaladivo kaladivo reopened this Dec 2, 2024
@kaladivo kaladivo removed the status in Development Kanban Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants
@kaladivo @leomira and others