Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin check for POST requests seems wrong #22

Open
benwiley4000 opened this issue Apr 1, 2019 · 0 comments
Open

Origin check for POST requests seems wrong #22

benwiley4000 opened this issue Apr 1, 2019 · 0 comments

Comments

@benwiley4000
Copy link
Contributor

I noticed when setting up the origin configuration for the fair analytics server that the server side logic doesn't make much sense. It's not possible for the origin configuration to equal both the host and hostname at the same time, and it shouldn't equal either of those since the origin header actually needs to include the network protocol (http:// or https://).

I gave a go at fixing it in my fork and I could make a PR if you'd like: benwiley4000@15eb9b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant