Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash on leader change #549

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Fixed crash on leader change #549

merged 2 commits into from
Jun 27, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jun 26, 2019

leader in storage:cpp2::ResultCode is an optional field, and get_leader() returns nullptr if not set.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jun 27, 2019
@dutor
Copy link
Contributor Author

dutor commented Jun 27, 2019

Jenkins, go!

@nebula-community-bot
Copy link
Member

Unit testing failed.

@dutor
Copy link
Contributor Author

dutor commented Jun 27, 2019

Jenkins go!

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 86eb34d into vesoft-inc:master Jun 27, 2019
@dutor dutor deleted the fix-crash-on-leader-change branch June 27, 2019 04:47
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
critical27 added a commit to critical27/nebula that referenced this pull request Aug 26, 2021
critical27 added a commit to critical27/nebula that referenced this pull request Aug 29, 2021
bright-starry-sky pushed a commit that referenced this pull request Aug 31, 2021
* get meta version in hb

* cherry-pick #549 #550 #551

* damn timeout

* fix rebuild index bug introduced in #2557
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
* get meta version in hb

* cherry-pick vesoft-inc#549 vesoft-inc#550 vesoft-inc#551

* damn timeout

* fix rebuild index bug introduced in vesoft-inc#2557

Co-authored-by: Doodle <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
Co-authored-by: cpw <[email protected]>

Co-authored-by: yaphet <[email protected]>
Co-authored-by: cpw <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
liwenhui-soul added a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
* Revert "Revert "disable zone commands (vesoft-inc#549)" (vesoft-inc#687)"

This reverts commit 4994543.

* Revert "Revert "disable add hosts into zone (vesoft-inc#560)" (vesoft-inc#688)"

This reverts commit d3cf535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants