Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect search for double-conversion: cmake scripts should be used #5870

Open
yurivict opened this issue Apr 28, 2024 · 0 comments
Open

Incorrect search for double-conversion: cmake scripts should be used #5870

yurivict opened this issue Apr 28, 2024 · 0 comments
Labels
affects/none PR/issue: this bug affects none version. severity/none Severity of bug type/bug Type: something is unexpected

Comments

@yurivict
Copy link

yurivict commented Apr 28, 2024

You look for the static library here . double-conversion can be installed as a shared library, so this algorithm is incorrect.

You should simply use cmake scripts provided by double-conversion:

find_package(double-conversion REQUIRED)

There's no need for cmake/FindDoubleConversion.cmake

Same problems exist for folly, fizz, and other libraries.
There's no need in writing Find*.cmake scripts for the packages that provide their own cmake scripts.

Your Environments (required)

  • OS: FreeBSD 14.0
  • Compiler: clang-18
  • Commit id: 494f48b
@yurivict yurivict added the type/bug Type: something is unexpected label Apr 28, 2024
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

1 participant