Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

union of SHOW EDGES and SHOW TAGS will crash graphd #5714

Open
wey-gu opened this issue Sep 11, 2023 · 2 comments
Open

union of SHOW EDGES and SHOW TAGS will crash graphd #5714

wey-gu opened this issue Sep 11, 2023 · 2 comments
Labels
affects/none PR/issue: this bug affects none version. hacktoberfest hacktoberfest events severity/none Severity of bug type/bug Type: something is unexpected

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Sep 11, 2023

This crashed graphd now.

SHOW EDGES
  union
SHOW TAGS
@wey-gu wey-gu added the type/bug Type: something is unexpected label Sep 11, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Sep 11, 2023
@wey-gu wey-gu added the hacktoberfest hacktoberfest events label Sep 26, 2023
@jyf111
Copy link

jyf111 commented Oct 18, 2023

The SHOW xxx operation returns a default iterator, but UNION/INTERSECT/MINUS assumes the iterator is sequential and does not have proper error handling, which leads to crash.

return finish(ResultBuilder()
.value(Value(std::move(dataSet)))
.iter(Iterator::Kind::kDefault)
.build());

DCHECK(left->isSequentialIter());

Similarly, SHOW EDGES | LIMIT 1 also crashes graphd.

Should we add more error handling or just support these operations? I guess the original intent of the default iterator does not allow these operations, so they should be disabled.

What is your expectation? @wey-gu

@zhanghuidinah
Copy link
Contributor

Hi @jyf111 The new year's hacktoberfest for developers has started. If you're interested, you're welcome to join us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. hacktoberfest hacktoberfest events severity/none Severity of bug type/bug Type: something is unexpected
Projects
Development

No branches or pull requests

3 participants