Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD HOSTS by cmd #5411

Closed
wqh17101 opened this issue Mar 17, 2023 · 5 comments
Closed

ADD HOSTS by cmd #5411

wqh17101 opened this issue Mar 17, 2023 · 5 comments
Labels
type/question Type: question about the product

Comments

@wqh17101
Copy link

I found that
image
We should use add hosts by myself to add, is there any options to add automatically?

@wey-gu
Copy link
Contributor

wey-gu commented Mar 17, 2023

This was intended to add human intervention in storaged service discovery, for those notified metad that they are ready to handle traffic, we need admin to explicitly "add"/activate to proceed.

In NebulaGraph k8s operator, this is not required as the operator will do so automatically.

@wqh17101
Copy link
Author

wqh17101 commented Mar 17, 2023

In NebulaGraph k8s operator, this is not required as the operator will do so automatically.

Why? Is there any trick in the dockfile or deployment.yaml to make it work?
@wey-gu

@wey-gu
Copy link
Contributor

wey-gu commented Mar 17, 2023

It's just the operator do the work, no workarounds actually, in docker-compose, such things existed, too, but in a silly way:

https://github.com/vesoft-inc/nebula-docker-compose/blob/0d47bbd5300758f80b60b805c035ad04e27cab34/docker-compose.yaml#L327

@wqh17101
Copy link
Author

Let me see.
Use dockerfile to start service and yaml to add hosts?
@wey-gu

@wey-gu
Copy link
Contributor

wey-gu commented Mar 17, 2023

It just waits for the cluster to be ready, and give a "one-shot" add hosts call at best, as docker-compose is not designed for production, we just leave it as is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Type: question about the product
Projects
None yet
Development

No branches or pull requests

3 participants