Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is Compaction algorithm in StorageD? #5039

Open
aminmaghsodi opened this issue Dec 11, 2022 · 4 comments
Open

What is Compaction algorithm in StorageD? #5039

aminmaghsodi opened this issue Dec 11, 2022 · 4 comments
Labels
type/question Type: question about the product

Comments

@aminmaghsodi
Copy link

aminmaghsodi commented Dec 11, 2022

What is Compaction algorithm in StorageD?
I don't see any information about the rocksdb compaction algorithm which is run on Storage In Nebula documentation.

@wey-gu
Copy link
Contributor

wey-gu commented Dec 12, 2022

@aminmaghsodi
Copy link
Author

As always, Thanks @wey-gu
I suggest to explain minor and major compaction algorithms in Compaction part of documentation. For example let's define in documentation that Nebula's minor compaction (Which is run in background) is X algorithm and when we run SUBMIT COMPACT, it is going to run Y algorithm. Is it a good idea?

Regards.

@wey-gu
Copy link
Contributor

wey-gu commented Dec 12, 2022

Dear @aminmaghsodi , you are always most welcome!

This is a good idea, we could provide more information on how to correlate different compactions to rocksdb compactions, to enable advanced users like you to know the needed context easier.

Are you interested in PR on this part?

Thanks!
BR// Wey

@aminmaghsodi
Copy link
Author

Yes of course I'd like to do it. :)

@Sophie-Xie Sophie-Xie added the type/question Type: question about the product label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Type: question about the product
Projects
None yet
Development

No branches or pull requests

3 participants