Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR proceeds when there are running jobs #4975

Closed
nebula-bots opened this issue Dec 2, 2022 · 0 comments
Closed

BR proceeds when there are running jobs #4975

nebula-bots opened this issue Dec 2, 2022 · 0 comments
Assignees
Labels
affects/master PR/issue: this bug affects master version. auto-sync process/done Process of bug severity/major Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@nebula-bots
Copy link
Contributor

Please check the FAQ documentation before raising an issue

Describe the bug (required)

We use br to backup the cluster when there are running balance data jobs(we ensure that the job is started before br backup and still running after backup finished), we expecte br to report error and exit, but it just proceeds and continue backup, the backup data might be inconsistent in this situation:

"time":"2022-12-02T15:29:46.055Z","uri":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/103"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/client/client.go:49","func":"github.com/vesoft-inc/nebula-agent/pkg/client.New","level":"debug","msg":"Dialing to address store5:8888.","time":"2022-12-02T15:29:46.055Z"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/storage/s3.go:312","func":"github.com/vesoft-inc/nebula-agent/pkg/storage.(*S3).GetDir","level":"debug","msg":"Get backend for s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/133 successfully.","time":"2022-12-02T15:29:46.055Z","uri":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/133"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/client/client.go:49","func":"github.com/vesoft-inc/nebula-agent/pkg/client.New","level":"debug","msg":"Dialing to address store1:8888.","time":"2022-12-02T15:29:46.055Z"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/storage/s3.go:312","func":"github.com/vesoft-inc/nebula-agent/pkg/storage.(*S3).GetDir","level":"debug","msg":"Get backend for s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/186 successfully.","time":"2022-12-02T15:29:46.056Z","uri":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/186"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/client/client.go:49","func":"github.com/vesoft-inc/nebula-agent/pkg/client.New","level":"debug","msg":"Dialing to address store4:8888.","time":"2022-12-02T15:29:46.056Z"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/storage/s3.go:312","func":"github.com/vesoft-inc/nebula-agent/pkg/storage.(*S3).GetDir","level":"debug","msg":"Get backend for s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/74 successfully.","time":"2022-12-02T15:29:46.056Z","uri":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/74"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/client/client.go:49","func":"github.com/vesoft-inc/nebula-agent/pkg/client.New","level":"debug","msg":"Dialing to address store4:8888.","time":"2022-12-02T15:29:46.056Z"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/storage/s3.go:312","func":"github.com/vesoft-inc/nebula-agent/pkg/storage.(*S3).GetDir","level":"debug","msg":"Get backend for s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/158 successfully.","time":"2022-12-02T15:29:46.056Z","uri":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/158"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/client/client.go:49","func":"github.com/vesoft-inc/nebula-agent/pkg/client.New","level":"debug","msg":"Dialing to address store5:8888.","time":"2022-12-02T15:29:46.056Z"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/storage/s3.go:312","func":"github.com/vesoft-inc/nebula-agent/pkg/storage.(*S3).GetDir","level":"debug","msg":"Get backend for s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/203 successfully.","time":"2022-12-02T15:29:46.056Z","uri":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data/71/203"}
{"data":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/data","file":"github.com/vesoft-inc/br-ent@/pkg/backup/full.go:118","func":"github.com/vesoft-inc/br-ent/pkg/backup.(*Backup).FullBackup","level":"info","msg":"Upload data backup successfully.","name":"BACKUP_2022_12_02_15_29_16","time":"2022-12-02T15:29:51.398Z"}
{"file":"github.com/vesoft-inc/br-ent@/pkg/backup/full.go:134","func":"github.com/vesoft-inc/br-ent/pkg/backup.(*Backup).FullBackup","level":"info","msg":"Write meta data to local tmp file successfully.","name":"BACKUP_2022_12_02_15_29_16","time":"2022-12-02T15:29:51.399Z","tmp path":"/tmp/nebula-br/BACKUP_2022_12_02_15_29_16.meta"}
{"file":"github.com/vesoft-inc/[email protected]/pkg/storage/s3.go:172","func":"github.com/vesoft-inc/nebula-agent/pkg/storage.(*S3).uploadToStorage","level":"debug","msg":"Upload from /tmp/nebula-br/BACKUP_2022_12_02_15_29_16.meta to graph1/BACKUP_2022_12_02_15_29_16/BACKUP_2022_12_02_15_29_16.meta successfully.","time":"2022-12-02T15:29:51.401Z"}
{"file":"github.com/vesoft-inc/br-ent@/pkg/backup/full.go:143","func":"github.com/vesoft-inc/br-ent/pkg/backup.(*Backup).FullBackup","level":"info","msg":"Upload tmp backup meta file to remote.","name":"BACKUP_2022_12_02_15_29_16","remote path":"s3://test/graph1/BACKUP_2022_12_02_15_29_16/BACKUP_2022_12_02_15_29_16.meta","time":"2022-12-02T15:29:51.401Z"}
{"file":"github.com/vesoft-inc/br-ent@/pkg/backup/full.go:151","func":"github.com/vesoft-inc/br-ent/pkg/backup.(*Backup).FullBackup","level":"info","msg":"Drop backup in cluster and local tmp folder successfully.","name":"BACKUP_2022_12_02_15_29_16","time":"2022-12-02T15:29:56.828Z"}
Full backup succeed.

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8) af513f9621154870e02ee865e67bf5bed5326b77 release-3.3

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

@nebula-bots nebula-bots added affects/none PR/issue: this bug affects none version. auto-sync severity/major Severity of bug type/bug Type: something is unexpected labels Dec 2, 2022
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Dec 2, 2022
@nebula-bots nebula-bots added affects/master PR/issue: this bug affects master version. and removed affects/none PR/issue: this bug affects none version. labels Dec 7, 2022
@github-actions github-actions bot added the process/fixed Process of bug label Dec 27, 2022
@HarrisChu HarrisChu added the process/done Process of bug label Jan 28, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/master PR/issue: this bug affects master version. auto-sync process/done Process of bug severity/major Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

4 participants