Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mechanism to handle huge query that timed out/OOM #4784

Open
wey-gu opened this issue Oct 26, 2022 · 3 comments
Open

add mechanism to handle huge query that timed out/OOM #4784

wey-gu opened this issue Oct 26, 2022 · 3 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Oct 26, 2022

Introduction

Some queries will end up with OOM and time out, but existing interface cannot help auto kill it

Contents

Related work

@wey-gu wey-gu added the type/enhancement Type: make the code neat or more efficient label Oct 26, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Oct 26, 2022

cc @MuYiYong

@bazingame
Copy link

bazingame commented Oct 26, 2022

I used nebula-explorer to find three steps expansion of one selected vertice accidentally. After I clicked the button Expand the explorer crashed. I can't ssh into the server and kill the query. I can't do anything just watch the server down.

Here are some metrics about the server during that time:

CPU global usage:

image

CPU status ratio:

image

Mem usage:
image

Mem status:
image

We think the query should be auto-killed by the nebula system which executed a long time or the memory usage up to a threshold configured. If the user used a wrong query statement or correct query without limitation, it will be very dangerous...

@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 31, 2023

Now, this should be mitigated/resolved by memtracker:

cc @bazingame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

2 participants