Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getNeighbors return error #4649

Closed
nevermore3 opened this issue Sep 15, 2022 · 2 comments · Fixed by #4671
Closed

getNeighbors return error #4649

nevermore3 opened this issue Sep 15, 2022 · 2 comments · Fixed by #4671
Assignees
Labels
severity/major Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@nevermore3
Copy link
Contributor

nevermore3 commented Sep 15, 2022

Please check the FAQ documentation before raising an issue

Describe the bug (required)

go from "Tony Parker" over like Where $^.player.age > 37 yield $^ as src

Filter $^.player.age > 37  pushdown to storage

getNeighbor's result is

 _vid|_stats|_tag:team:_tag:name|_tag:player:_tag:age:name|_tag:bachelor:_tag:name:speciality|_edge:+like:_dst|_expr|
 "Tony Parker"|__EMPTY__|__EMPTY__|[10,36,"Tony Parker"]|__EMPTY__|__EMPTY__|__EMPTY__|

go from "Tony Parker" over like Where like.likeness > 100 yield $^ as src

Filter like.likeness>100 pushdown to storage

getNeighbor's result is

 _vid|_stats|_tag:team:_tag:name|_tag:player:_tag:age:name|_tag:bachelor:_tag:name:speciality|_edge:+like:_dst|_expr|
 "Tony Parker"|__EMPTY__|__EMPTY__|[10,36,"Tony Parker"]|__EMPTY__|__EMPTY__|__EMPTY__|

There will be an error when taking the vertex (should not be return)

Expect
go from "Tony Parker" over like Where $^.player.age > 36 yield $^ as src

getNeighbor's result is

 _vid|_stats|_tag:team:_tag:name|_tag:player:_tag:age:name|_tag:bachelor:_tag:name:speciality|_edge:+like:_dst|_expr|

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

@nevermore3 nevermore3 added the type/bug Type: something is unexpected label Sep 15, 2022
@Sophie-Xie Sophie-Xie added this to the v3.3.0 milestone Sep 16, 2022
@nevermore3 nevermore3 mentioned this issue Sep 16, 2022
11 tasks
@critical27
Copy link
Contributor

Em... GetNeighbors's filter is designed for edge's filter only at the first time...

go from "Tony Parker" over like Where $^.player.age > 37 yield $^ as src

We could fix it in storage indeed. But how do we handle an expression when contains both tag and edge?

I think there is a way which won't introduce too much changes: only push down edge's filter...

@nevermore3
Copy link
Contributor Author

Logically, we should distinguish whether the tag is not satisfied the condition or the edge is not satisfied the condition, if the tag is not satisfied return nothing else return a record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants