Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit job compact can be stopped #4419

Closed
Sophie-Xie opened this issue Jul 14, 2022 · 1 comment
Closed

submit job compact can be stopped #4419

Sophie-Xie opened this issue Jul 14, 2022 · 1 comment
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@Sophie-Xie
Copy link
Contributor

Sophie-Xie commented Jul 14, 2022

Describe the background of the requirement

  • user want to stop the compaction job

Describe the detail of the requirement

  • just provide a stop command to stop the compaction job

Describe the scenarios of the requirement

  • the compaction job run a long time and didn't know when it will stop or the compaction affect the performance

from @dbacyj

@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Jul 14, 2022
@Sophie-Xie Sophie-Xie added this to the v3.3.0 milestone Jul 14, 2022
@critical27
Copy link
Contributor

Rocksdb does provide an interface to stop it, it has an CancelAllBackgroundWork, but it is used when shutting down.
If we use it as a stop or cancel, upcoming compact will return error like below, even if the server is not shutting down.

W20220726 16:00:06.155649 1525392 RocksEngine.cpp:499] CompactAll Failed: Shutdown in progress: Database shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

2 participants