Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk fault recovery #4123

Closed
Sophie-Xie opened this issue Apr 8, 2022 · 3 comments · Fixed by #4131
Closed

Disk fault recovery #4123

Sophie-Xie opened this issue Apr 8, 2022 · 3 comments · Fixed by #4131
Assignees
Labels
type/feature req Type: feature request
Milestone

Comments

@Sophie-Xie
Copy link
Contributor

Describe the background of the requirement

  • Considering that a node has multiple data paths, there is no need to rebuild the entire node when the disk corresponding to a data path fails.

Describe the detail of the requirement

  • After the disk corresponding to the data path is repaired, the original part data can be automatically restored to the data path.

Describe the scenarios of the requirement

  • Disk failback, not node failback

Describe the priority

  • Urgency: hi
  • Importance: hi
@Sophie-Xie Sophie-Xie added the type/feature req Type: feature request label Apr 8, 2022
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.2.0 and Tools Apr 8, 2022
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Apr 8, 2022
@critical27
Copy link
Contributor

critical27 commented Apr 8, 2022

Try this example, a storage start with 2 data paths, say p1, p2.

  1. create a space, so both p1 and p2 has some parts
  2. stop storage, remove the data in p1
  3. restart storage, ideally the deleted parts would start on p1, but based on current implementation, I guess the part will only put to p2.

See NebulaStore::loadPartFromPartManager() for details, we won't rebuild the kvengine in p1, so the partitions removed in step2 will only be added to p2

image

@wenhaocs
Copy link
Contributor

wenhaocs commented Apr 8, 2022

How about disk balance feature?

@Sophie-Xie
Copy link
Contributor Author

How about disk balance feature?

Maybe in 5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants