Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https client for es syntax and meta data enhancement #3344

Closed
critical27 opened this issue Nov 23, 2021 · 0 comments
Closed

https client for es syntax and meta data enhancement #3344

critical27 opened this issue Nov 23, 2021 · 0 comments
Labels
priority/low-pri Priority: low type/enhancement Type: make the code neat or more efficient

Comments

@critical27
Copy link
Contributor

critical27 commented Nov 23, 2021

In #3150 we have supported https client for es, but the syntax is weird:

SIGN IN TEXT SERVICE (127.0.0.1:9200, HTTP);
SIGN IN TEXT SERVICE (127.0.0.1:9200, HTTP, "user", "password");
SIGN IN TEXT SERVICE (127.0.0.1:9200, HTTPS, "user", "password");

Actually, we could simplify the syntax as belows, which involve a meta format change, see #3150 (comment) for details:

SIGN IN TEXT SERVICE 
  (http://127.0.0.1:9200, "user", "password"),
  (https://127.0.0.1:9200, "user", "password")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low-pri Priority: low type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

2 participants