RETURN timestamp(-1) returns BAD_DATA

[randomJoe211]

As the title states. An error should be a more logical return, right?

[laura-ding]

As the title states. An error should be a more logical return, right?

TIMESTAMP has a range of 1970-01-01 00:00:01 UTC to 2262-04-11 23:47:16 UTC. So if out of range , it's the bad_data

[randomJoe211]

BAD_DATA is confusing. Maybe raise an error and list the supported argument type and range.

[laura-ding]

BAD_DATA is confusing. Maybe raise an error and list the supported argument type and range.

All functions through return BAD_DATA to tell the user the calculation result is wrong. If the type is wrong, it will return an error.

[jievince]

BAD_DATA is confusing. Maybe raise an error and list the supported argument type and range.

All functions through return BAD_DATA to tell the user the calculation result is wrong. If the type is wrong, it will return an error.

As @czpmango said, expression::eval() may return StatusOr to report detailed error msg

[czpmango]

BAD_DATA is confusing. Maybe raise an error and list the supported argument type and range.

Your are right. We will modify the error passing mechanism of the expression later.

[czpmango]

BAD_DATA is confusing. Maybe raise an error and list the supported argument type and range.

All functions through return BAD_DATA to tell the user the calculation result is wrong. If the type is wrong, it will return an error.

As @czpmango said, expression::eval() may return StatusOr to report detailed error msg

ACK. But it maybe a big change on implementation layer.

[czpmango]

There are so many differences between our time-related function and CYPHER's, some of which in https://github.com/vesoft-inc/nebula-graph/issues/676

[Shylock-Hg]

Raise error in this case that meet the invalid parameter value is not well, some the input come from previous output and it's also get from previous executor so there may contain valid and invalid data together, user can't know is it valid always.

[Sophie-Xie]

It is in control, so we suggest to close it.