Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS issue after TLS termination #599

Closed
wey-gu opened this issue Aug 7, 2023 · 7 comments · Fixed by #586
Closed

WS issue after TLS termination #599

wey-gu opened this issue Aug 7, 2023 · 7 comments · Fixed by #586
Assignees
Labels
affects/none PR/issue: this bug affects none version. hacktoberfest process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Aug 7, 2023

Describe the bug (must be provided)

When studio is behind HTTPS/WSS, it'll got WebSocket ERROR.

Your Environments (must be provided)

  • Studio-version: 3.7.0

How To Reproduce(must be provided)

Steps to reproduce the behavior:

With this docker compose yaml and nginx.conf, we could easily reproduced the issue.

version: '3.4'
services:
  web:
    image: vesoft/nebula-graph-studio:v3.7.0
    environment:
      USER: root
    ports:
      - 7001
    networks:
      - nebula-net
  nginx:
    image: nginx:1.17.6
    ports:
      - 7001:443
    volumes:
      - ./nginx.conf:/etc/nginx/nginx.conf
      - ./cert:/cert
    networks:
      - nebula-net

networks:
  nebula-net:
    external: true

nginx.conf:

events {
}

http {
    server {
        listen 443 ssl;
        server_name nebula-demo.siwei.io;
        ssl_certificate /cert/fullchain.pem;
        ssl_certificate_key /cert/privkey.pem;
        location / {
            proxy_pass http://web:7001;
        }

        location /nebula_ws {
            proxy_pass http://web:7001;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
        }
    }
}

Expected behavior

working

Additional context

Screen Captured as follow:

Screen.Recording.2023-08-07.at.18.02.54.mp4
@wey-gu wey-gu added the type/bug Type: something is unexpected label Aug 7, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Aug 7, 2023
@wey-gu
Copy link
Contributor Author

wey-gu commented Aug 10, 2023

cc @hetao92 :-D

@sbocahu
Copy link

sbocahu commented Oct 12, 2023

we reproduce the same issue with nginx-ingress controller with tls termination in front of a nebule-studio helm-deployed instance on kubernetes

any workaround or fix you know of ?

@salahaz
Copy link

salahaz commented Nov 6, 2023

@wey-gu any updates on this issue ?

@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 7, 2023

After checking with @huaxiabuluo to know it's already fixed in 3.8.0 release, and I verified to confirm it's fixed :)

@wey-gu wey-gu closed this as completed Nov 7, 2023
@github-project-automation github-project-automation bot moved this from Accepted to Done in Product Backlog Nov 7, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in hacktoberfest 2023 Nov 7, 2023
@wey-gu wey-gu added the process/fixed Process of bug label Nov 7, 2023
@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 7, 2023

3.8.0 over wss in container

3.8.0.regression.mov

@huaxiabuluo huaxiabuluo mentioned this issue Nov 7, 2023
3 tasks
@huaxiabuluo
Copy link
Contributor

huaxiabuluo commented Nov 7, 2023

@salahaz @sbocahu
Under the HTTPS protocol, the WebSocket service link prefix needs to be changed from ws:// to wss://, this bug has been fixed in version 3.8, please upgrade to the latest version.

@salahaz
Copy link

salahaz commented Nov 13, 2023

Thank you very much @wey-gu and @huaxiabuluo for your support!!! It is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. hacktoberfest process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants