Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Balance Leader Multiple Times During Balance Data Until There's a Valid Partition Under "Leader Distribution" #520

Closed
kevinliu24 opened this issue Aug 17, 2024 · 0 comments · Fixed by #532
Closed

Call Balance Leader Multiple Times During Balance Data Until There's a Valid Partition Under "Leader Distribution" #520

kevinliu24 opened this issue Aug 17, 2024 · 0 comments · Fixed by #532
Assignees
@kevinliu24
Labels
affects/v1.8 PR/Issue: this bug affects v1.8.x version. severity/major Severity of bug type/enhancement Type: make the code neat or more efficient

Comments

@kevinliu24
Copy link
Contributor

Introduction
Currently Balance Data only calls Balance Leader once, but this does not guarantee that the leader will be balanced. This was also experienced by Snap.

Contents
We should call balance leader until there's a valid partition under the leader distribution.
@kevinliu24 kevinliu24 added the type/enhancement Type: make the code neat or more efficient label Aug 17, 2024
@kevinliu24 kevinliu24 self-assigned this Aug 17, 2024
@wey-gu wey-gu mentioned this issue Aug 24, 2024
Open
@kevinliu24 kevinliu24 added severity/major Severity of bug affects/v1.8 PR/Issue: this bug affects v1.8.x version. labels Nov 1, 2024
@kevinliu24 kevinliu24 mentioned this issue Nov 9, 2024
Merged
3 tasks
@kevinliu24 kevinliu24 linked a pull request Nov 9, 2024 that will close this issue
[operator] run leader balance multiple times until balanced. #532
Merged
3 tasks
@wey-gu wey-gu mentioned this issue Nov 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinliu24 kevinliu24

Labels
affects/v1.8 PR/Issue: this bug affects v1.8.x version. severity/major Severity of bug type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[operator] run leader balance multiple times until balanced. vesoft-inc/nebula-operator
1 participant
@kevinliu24