Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamic param]when change value of prioritize_intra_zone_reading, pod restart #315

Closed
jinyingsunny opened this issue Oct 7, 2023 · 4 comments
Closed

[dynamic param]when change value of prioritize_intra_zone_reading, pod restart #315

jinyingsunny opened this issue Oct 7, 2023 · 4 comments
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected wontfix Solution: this will not be worked on

Comments

@jinyingsunny
Copy link

when edit nc nebulazcert ,change value of prioritize_intra_zone_reading, pod restart ,since it belongs to dynamic param, should not restart pod.
image

Your Environments (required)

nebula-operator: snap-1.18

Expected behavior

without restart, but Immediate effect
@jinyingsunny jinyingsunny added the type/bug Type: something is unexpected label Oct 7, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Oct 7, 2023
@MegaByte875
Copy link
Contributor

nebula-operator/apis/apps/v1alpha1/nebulacluster.go

Line 125 in 55f4dc9

func (nc *NebulaCluster) IsIntraZoneReadingEnabled() bool {

This flag controls the node-label container attached when the graphd pod template is generated.

@MegaByte875
Copy link
Contributor

#319

@jinyingsunny
Copy link
Author

#319

只是从动态参数中做了移除。
对应的需求是：#282

@jinyingsunny jinyingsunny added the wontfix Solution: this will not be worked on label Oct 10, 2023
@github-actions github-actions bot added the process/fixed Process of bug label Oct 10, 2023
@jinyingsunny jinyingsunny mentioned this issue Oct 10, 2023
Closed
@jinyingsunny jinyingsunny added process/done Process of bug and removed process/fixed Process of bug labels Oct 10, 2023
@wenhaocs
Copy link

nebula-operator/apis/apps/v1alpha1/nebulacluster.go

Line 125 in 55f4dc9

func (nc *NebulaCluster) IsIntraZoneReadingEnabled() bool {

This flag controls the node-label container attached when the graphd pod template is generated.

Is it because of this line: https://github.com/vesoft-inc/nebula-operator/blob/master/apis/apps/v1alpha1/nebulacluster_common.go#L477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected wontfix Solution: this will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MegaByte875 @wenhaocs @jinyingsunny