Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need thrift generated files to meta and storage? #242

Closed
lee-qiu opened this issue Jan 9, 2023 · 2 comments
Closed

Do we need thrift generated files to meta and storage? #242

lee-qiu opened this issue Jan 9, 2023 · 2 comments

Comments

@lee-qiu
Copy link

lee-qiu commented Jan 9, 2023

It seems that we don't use those thrift generated files to meta and storage in go client repo but keep updating with engine, does this make any sense?

@wey-gu
Copy link
Contributor

wey-gu commented Jan 9, 2023

@Aiee what do you think?

Maybe someday we'll add abstraction for meta/storage clients in GO clients?

@Aiee
Copy link
Contributor

Aiee commented Jan 12, 2023

The main purpose for keeping them in this repo is that some other tools(some may be internal) may include nebula-go as a library and use these files.

i.g. If we want to do a stress test to test the storage I/O, we could use the interface of storage to connect storage directly instead of sending queries to the graph service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants