Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm64 docker build #174

Closed
wey-gu opened this issue Aug 24, 2022 · 3 comments · Fixed by #176
Closed

add arm64 docker build #174

wey-gu opened this issue Aug 24, 2022 · 3 comments · Fixed by #176
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Aug 24, 2022

as titled.

@artemijspavlovs
Copy link
Contributor

I would like to add this, it seems though that the docker/build-push-action@v1 might only support it with the build_args property while docker/build-push-action@v3 supports it natively with the platforms property.

do you have anything against/are there any known implications for bumping the version of this action?

@wey-gu
Copy link
Contributor Author

wey-gu commented Aug 24, 2022

Wow, thanks a lot @artemijspavlovs !

I don't think it's kept v1 for any purposes as this is just a single binary container.

We were using v2 in NebulaGraph Core.

@jievince correct me if wrong.

Thanks again @artemijspavlovs.

@wey-gu
Copy link
Contributor Author

wey-gu commented Aug 24, 2022

Just assigned to you, please take your time and ping me for anything I could help @artemijspavlovs :), here or via slack/etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants