Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider non-binary deployment use case #22

Open
wey-gu opened this issue Jul 25, 2022 · 3 comments
Open

consider non-binary deployment use case #22

wey-gu opened this issue Jul 25, 2022 · 3 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link

wey-gu commented Jul 25, 2022

Now, the agent calls the service script with bash with the assumptions that the agent is running together with the service:

  1. with same hostname
  2. sharing same filesystem, home path & service was started with scripts/nebula.service stop

func (d *ServiceDaemon) Stop() error {
cmdStr := fmt.Sprintf("cd %s && scripts/nebula.service stop %s", d.s.dir, d.s.name)
log.WithField("cmd", cmdStr).Debug("Try to stop service...")
cmd := exec.Command("bash", "-c", cmdStr)
err := cmd.Run()
if err != nil {

For 1. it's do able like a sidecar design in both docker and k8s:

https://github.com/wey-gu/nebula-up/blob/9bd28601f9cb156d77009c724f09164b02f07393/backup_restore/docker-compose.yaml#L54-L59

While for 2. it's really hard to mitigate, introducing hooks to make this work is too hacky.

We need to revisit the design to enable service stop/start w/o assuming leveraging scripts.

@wey-gu
Copy link
Author

wey-gu commented Aug 30, 2022

user report failure of BR in k8s:

@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Nov 30, 2022
@Lichil
Copy link

Lichil commented Nov 7, 2023

咨询下,在 br 支撑 k8s 环境备份有下一步计划吗?

@wenhaocs
Copy link

wenhaocs commented Nov 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

4 participants