Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading .github/ISSUE_TEMPLATE as a folder #388

Open
junjizhi opened this issue Nov 15, 2018 · 3 comments
Open

Support reading .github/ISSUE_TEMPLATE as a folder #388

junjizhi opened this issue Nov 15, 2018 · 3 comments
Labels
enhancement idea for a new feature or refinement of existing functionality

Comments

@junjizhi
Copy link
Contributor

Github supports multiple issue templates in a .github/ISSUE_TEMPLATE
folder. When I submit an issue on a repo with that settings, I got the
following error:

Debugger entered--Lisp error: (file-error "Read error" "Is a directory" "/Users/junjizhi/projects/repo/.github/ISSUE_TEMPLATE")
  insert-file-contents("/Users/junjizhi/projects/repo/.github/ISSUE_TEMPLATE")
  ...
  magithub-issue--template-text("ISSUE_TEMPLATE")
  magithub-issue-new(((id . 157747011)  
  call-interactively(magithub-issue-new)
  magit-invoke-popup-action(105)
  funcall-interactively(magit-invoke-popup-action 105)
  call-interactively(magit-invoke-popup-action nil nil)
  command-execute(magit-invoke-popup-action)

@junjizhi junjizhi changed the title Support for multiple issue templates Support reading .github/ISSUE_TEMPLATE as a folder Nov 16, 2018
@vermiculus
Copy link
Owner

If ISSUE_TEMPLATE is a folder, are each of the files inside a possible template? Is there any documentation from GitHub on this?

@junjizhi
Copy link
Contributor Author

@vermiculus yes, here's the doc.

The template query parameter works with templates stored in an ISSUE_TEMPLATE or PULL_REQUEST_TEMPLATE subdirectory within the root,

@vermiculus vermiculus added the enhancement idea for a new feature or refinement of existing functionality label Nov 16, 2018
@vermiculus
Copy link
Owner

Thanks for the info -- I can take a look at this, but it may be a while. I would of course make time to review a PR if one came my way :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement idea for a new feature or refinement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants