You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm still a bit new to Emacs so forgive my ignorance if I'm wrong...but I think the convention across most Emacs packages is that x-mode's keymap is x-mode-map, so the variable magithub-dash-map should probably be magithub-dash-mode-map, right?
For backwards compatibility, perhaps you could just alias magithub-dash-mode-map to magithub-dash-map?
For background, I ran into this issue when trying to bind some custom keys for the magithub dashboard via magithub-dash-mode-map. My keybindings showed up in the help when I did C-h m, but were not actually doing anything until I bound them to magithub-dash-map.
The text was updated successfully, but these errors were encountered:
A fooey, you're absolutely right. I don't think an alias is necessary here since a stable version has not yet been released – or maybe we can add the alias and tell ourselves to remove it upon 1.0.
vermiculus
added
bug
describes a defect in supported/advertised functionality
easy
good, bite-sized issue for new developers
labels
May 27, 2018
I'm still a bit new to Emacs so forgive my ignorance if I'm wrong...but I think the convention across most Emacs packages is that
x-mode
's keymap isx-mode-map
, so the variablemagithub-dash-map
should probably bemagithub-dash-mode-map
, right?For backwards compatibility, perhaps you could just alias
magithub-dash-mode-map
tomagithub-dash-map
?For background, I ran into this issue when trying to bind some custom keys for the magithub dashboard via
magithub-dash-mode-map
. My keybindings showed up in the help when I didC-h m
, but were not actually doing anything until I bound them tomagithub-dash-map
.The text was updated successfully, but these errors were encountered: