Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias magithub-dash-mode-map to magithub-dash-map #336

Open
ashiklom opened this issue May 27, 2018 · 1 comment
Open

Alias magithub-dash-mode-map to magithub-dash-map #336

ashiklom opened this issue May 27, 2018 · 1 comment
Labels
bug describes a defect in supported/advertised functionality easy good, bite-sized issue for new developers

Comments

@ashiklom
Copy link

I'm still a bit new to Emacs so forgive my ignorance if I'm wrong...but I think the convention across most Emacs packages is that x-mode's keymap is x-mode-map, so the variable magithub-dash-map should probably be magithub-dash-mode-map, right?

For backwards compatibility, perhaps you could just alias magithub-dash-mode-map to magithub-dash-map?

For background, I ran into this issue when trying to bind some custom keys for the magithub dashboard via magithub-dash-mode-map. My keybindings showed up in the help when I did C-h m, but were not actually doing anything until I bound them to magithub-dash-map.

@vermiculus
Copy link
Owner

A fooey, you're absolutely right. I don't think an alias is necessary here since a stable version has not yet been released – or maybe we can add the alias and tell ourselves to remove it upon 1.0.

@vermiculus vermiculus added bug describes a defect in supported/advertised functionality easy good, bite-sized issue for new developers labels May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug describes a defect in supported/advertised functionality easy good, bite-sized issue for new developers
Projects
None yet
Development

No branches or pull requests

2 participants