Change behaviour of "On fewerstatistics 0" #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Never print statistics for small buffer sort, if ShortStatsMax is 0
|
Does anyone have any opinions on this? It's a trivial change, but I am re-applying it every time I pull new commits from the repo... |
|
I think this is OK to merge; hopefully, no one relies on the old behaviour of |
|
@vermaseren |
|
I guess it is OK.
Internally it affects only the printing of the statistics in the WriteStats routine as far as I know.
It may change some outputs in the sense that the number of statistics printouts changes.
This again could potentially affect scripts that process outputs.
But the value 1 is still available and it would probably be rather easy to spot this and
also very easy to repair, using grep.
Just do not forget to change the manual.
Jos
… On 17 Jul 2020, at 12:35, Takahiro Ueda ***@***.***> wrote:
@vermaseren <https://github.com/vermaseren>
Jos, is it OK to merge? This is backwards-incompatible, in a strict sense. Maybe you know some background of the decision of the behaviour of fewerstatistics 0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#285 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJPCEXTF7K3TOP6C3AEMH3R4ASOJANCNFSM4FF4B6LQ>.
|
|
The document change is also included in this pull request, so I will merge it... |
|
It looks like the change in |
|
OK, I will re-apply it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never print statistics for small buffer sort, if ShortStatsMax is 0
Often I want statistics enabled, but only for the final sort (to see the number of terms in output).
For large calculations, one can get many thousands of lines for small-buffer sorts, even with fewerstats set as large as possible.