Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Support #209

Closed
givsta opened this issue Jun 7, 2018 · 7 comments
Closed

Video Support #209

givsta opened this issue Jun 7, 2018 · 7 comments
Labels
TYPE: Enhancement

Comments

@givsta
Copy link

givsta commented Jun 7, 2018

Hi @verlok

Just wanted to find out if there is video support?

Thank you.
@verlok
Copy link
Owner

verlok commented Jun 11, 2018

That shouldn't be a big deal to implement. Will check.

@givsta
Copy link
Author

givsta commented Jun 12, 2018

Awesome, thank you! 😀

@verlok
Copy link
Owner

verlok commented Jun 19, 2018

@gvenm I started working on it today, I confirm it should be quite easy to do. I'll keep you updated.

@verlok
Copy link
Owner

verlok commented Jun 20, 2018 •
edited
Loading

@gvenm you can see the few changes I did in this commit and this commit. It's still on a feature branch, need to add some tests on it, then merge it to master.

@givsta
Copy link
Author

givsta commented Jun 20, 2018

This is brilliant! Appreciate this @verlok

@verlok
Copy link
Owner

verlok commented Jun 22, 2018

Done and released 10.7.0.
Not yet released in 8.x version.

@verlok
Copy link
Owner

verlok commented Jun 23, 2018

Done! https://twitter.com/vanillaLazyload/status/1010404143662497793

@verlok verlok closed this as completed Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TYPE: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@verlok @givsta