-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JOSS] Paper minor corrections #452
Comments
Can you add my FWO number to the publication? |
Refer to the documentation (version) for more details: Further reading and citations needed here “55 to examine data types, irregular timestamps, max-min thresholds, repetitions criteria, spike tests, allowed variation in time windows and spatial tests” (Vergauwen et al., 2024, p. 3) (pdf) These, IMHO, are quite involved methods. What are the formal basis behind these QC methods or are they based on intuition? Some reuses TITAN (titanlib) while the rest are implemented from the scratch (which means citing TITAN alone will not be sufficient). . “59 ... gap filling is applied by using interpolation methods” (Vergauwen et al., 2024, p. 3) (pdf) Gap filling and bias correction is another involved topic. What is the basis behind the methods used? Further reading and citations needed here. |
When referring to a class of the toolkit i used recursive. |
Minor corrections suggestions by @ashwinvis:
“48 ... data for analysis by making intensive use of the pandas (The pandas development team, 2023) and geopandas (Jordahl et al., 2020) functionalities” (Vergauwen et al., 2024, p. 2) (pdf)
*use of the functionalities from pandas (..) and geopandas (..) libraries.
“52 data is imported into the Toolkit Dataset” (Vergauwen et al., 2024, p. 3) (pdf)
into a Toolkit Dataset class instance
“61 Modeldata” (Vergauwen et al., 2024, p. 3) (pdf)
Modeldata class instance
Finally could you make the typography consistent between
Toolkit Dataset
Toolkit Modeldata
Toolkit-Analysis
?
The text was updated successfully, but these errors were encountered: