Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Paper minor corrections #452

Closed
vergauwenthomas opened this issue Feb 28, 2024 · 4 comments · Fixed by #454
Closed

[JOSS] Paper minor corrections #452

vergauwenthomas opened this issue Feb 28, 2024 · 4 comments · Fixed by #454
Assignees
Labels
easy Priority This issue has priority

Comments

@vergauwenthomas
Copy link
Owner

Minor corrections suggestions by @ashwinvis:

“48 ... data for analysis by making intensive use of the pandas (The pandas development team, 2023) and geopandas (Jordahl et al., 2020) functionalities” (Vergauwen et al., 2024, p. 2) (pdf)

*use of the functionalities from pandas (..) and geopandas (..) libraries.

“52 data is imported into the Toolkit Dataset” (Vergauwen et al., 2024, p. 3) (pdf)

into a Toolkit Dataset class instance

“61 Modeldata” (Vergauwen et al., 2024, p. 3) (pdf)

Modeldata class instance

Finally could you make the typography consistent between

Toolkit Dataset
Toolkit Modeldata
Toolkit-Analysis
?

@vergauwenthomas vergauwenthomas added Priority This issue has priority easy labels Feb 28, 2024
@vergauwenthomas vergauwenthomas self-assigned this Feb 28, 2024
@vergauwenthomas
Copy link
Owner Author

Ref: openjournals/joss-reviews#5916

@amberJ99
Copy link
Collaborator

Can you add my FWO number to the publication?
My number is 11PBN24N.

@vergauwenthomas
Copy link
Owner Author

Refer to the documentation (version) for more details:

Further reading and citations needed here
Since MetObs-Toolkit implements quite a few methods, it would be important to link to other sources which may describe them in detail. If you think that these methods might be subject to change, it might be sufficient to cite the references in the online documentation and link this software paper to the documentation instead. See how scikit-image does it.

“55 to examine data types, irregular timestamps, max-min thresholds, repetitions criteria, spike tests, allowed variation in time windows and spatial tests” (Vergauwen et al., 2024, p. 3) (pdf)

These, IMHO, are quite involved methods. What are the formal basis behind these QC methods or are they based on intuition? Some reuses TITAN (titanlib) while the rest are implemented from the scratch (which means citing TITAN alone will not be sufficient). .

“59 ... gap filling is applied by using interpolation methods” (Vergauwen et al., 2024, p. 3) (pdf)

Gap filling and bias correction is another involved topic. What is the basis behind the methods used? Further reading and citations needed here.

@vergauwenthomas vergauwenthomas linked a pull request Feb 29, 2024 that will close this issue
@vergauwenthomas
Copy link
Owner Author

Finally could you make the typography consistent between

Toolkit Dataset Toolkit Modeldata Toolkit-Analysis ?

When referring to a class of the toolkit i used recursive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Priority This issue has priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants