-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JOSS] Paper Commentary #387
Comments
Other comments:
|
@ashwinvis, you mentioned in 5916 an issue in the paper:
(@Zeitsperre, mentioned the pandas citation as well.) IssueI am trying to solve them in PR #400. The problem is that the references are correct present in the paper.bib, but are formatted by pandoc assuming the author to be a persons name and not FixI could not find any option to force full-author-format in pandoc, so i came up with this "fix":
and in the Bibliography as: Is this oke?I know this is not a clean fix, but I could not find how to do it any other way. Do you think this fix is oke, or do you have a better idea? |
@ashwinvis, you mentioned this issue: References: Fix Caluwaerts et al. title The urban climate of ghent, belgium... and the citation for Pandas. However, I cannot find a way on how to force capital letters for Ghent and Belgium because they are written in capital in the paper.bib:
@ashwinvis, any idea on how to solve this? |
Yes title = {The urban climate of {G}hent, {B}elgium : a case study combining a high-accuracy monitoring network with numerical simulations}, |
@vergauwenthomas The latest draft of the paper addresses many of the issues I raised (and flows much better). There are a handful of small grammatical errors that I can fix if you'd like (let me know), but I consider this issue addressed! |
@Zeitsperre thanks! If you could pinpoint the grammatical errors that would be great, but only if you have time for it. (If you do, and prefer to fix the errors in the paper.md you are free to do so.) btw #400 is merged to master. |
Context: openjournals/joss-reviews#5916
This is a list of some recommendations that could help with the paper submission:
"team, T. pandas development"
There are a handful of phrases that could be tightened as well (if the authors like, I can suggest a few changes in a PR). I might also have some small additional comments after more reflection.
The text was updated successfully, but these errors were encountered: