-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating empty scramble should throw exception #351
Comments
I'm sorry that no one has been following up with this issue. @dongyoungy Can you take a look into this? The fix seems to be pretty straightforward. |
I have already asked Jiacheng to look at an efficient way of determining an empty table to solve this issue. |
I see. That's great. |
No worries, thank you! |
Hi, I have created a pull request to solve this problem. In the process of creating scramble, it will throw a VerdictDBException when empty table is detected. |
@commercial-hippie FYI, the fix for this issue has been merged into master. |
When a scramble is created on a empty data set I think it should throw an error to avoid broken scrambles. (I tried to append to the scramble later).
Here is a example I got from a scramble on a empty table:
The text was updated successfully, but these errors were encountered: