Skip to content

Commit

Permalink
fix: click on logo break ui (#1071)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ayusharma @juanpicado
ayusharma authored and juanpicado committed Oct 12, 2018
1 parent 8281b8d commit 5b34dc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/webui/components/Header/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ class Header extends Component<IProps, IState> {
}

renderLeftSide(): Node {
const { registryUrl } = this.state;
return (
<a href="{registryUrl}/#/">
<a href={`${registryUrl}/#/`}>
<Logo />
</a>
);
Expand Down
4 changes: 2 additions & 2 deletions test/unit/webui/components/__snapshots__/header.spec.js.snap
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`<Header /> component with logged in state should load the component in logged in state 1`] = `"<header class=\\"MuiPaper-root-10 MuiPaper-elevation4-16 MuiAppBar-root-1 MuiAppBar-positionStatic-5 MuiAppBar-colorPrimary-8 css-6njnwn e1ctrp120\\"><div class=\\"MuiToolbar-root-37 MuiToolbar-regular-39 MuiToolbar-gutters-38 css-ioebmw e1ctrp121\\"><a href=\\"{registryUrl}/#/\\"><div class=\\"css-guljh6 e18wxr160\\"></div></a><div><a href=\\"https://verdaccio.org/docs/en/installation\\" target=\\"_blank\\" tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" role=\\"button\\" title=\\"Documentation\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 17h-2v-2h2v2zm2.07-7.75l-.9.92C13.45 12.9 13 13.5 13 15h-2v-.5c0-1.1.45-2.1 1.17-2.83l1.24-1.26c.37-.36.59-.86.59-1.41 0-1.1-.9-2-2-2s-2 .9-2 2H8c0-2.21 1.79-4 4-4s4 1.79 4 4c0 .88-.36 1.68-.93 2.25z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></a><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" type=\\"button\\" id=\\"header--button-registryInfo\\" title=\\"Registry Information\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 15h-2v-6h2v6zm0-8h-2V7h2v2z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></button><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" type=\\"button\\" id=\\"header--button-account\\" aria-owns=\\"sidebar-menu\\" aria-haspopup=\\"true\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm0 3c1.66 0 3 1.34 3 3s-1.34 3-3 3-3-1.34-3-3 1.34-3 3-3zm0 14.2c-2.5 0-4.71-1.28-6-3.22.03-1.99 4-3.08 6-3.08 1.99 0 5.97 1.09 6 3.08-1.29 1.94-3.5 3.22-6 3.22z\\"></path><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></button></div></div></header>"`;
exports[`<Header /> component with logged in state should load the component in logged in state 1`] = `"<header class=\\"MuiPaper-root-10 MuiPaper-elevation4-16 MuiAppBar-root-1 MuiAppBar-positionStatic-5 MuiAppBar-colorPrimary-8 css-6njnwn e1ctrp120\\"><div class=\\"MuiToolbar-root-37 MuiToolbar-regular-39 MuiToolbar-gutters-38 css-ioebmw e1ctrp121\\"><a href=\\"http://localhost/#/\\"><div class=\\"css-guljh6 e18wxr160\\"></div></a><div><a href=\\"https://verdaccio.org/docs/en/installation\\" target=\\"_blank\\" tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" role=\\"button\\" title=\\"Documentation\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 17h-2v-2h2v2zm2.07-7.75l-.9.92C13.45 12.9 13 13.5 13 15h-2v-.5c0-1.1.45-2.1 1.17-2.83l1.24-1.26c.37-.36.59-.86.59-1.41 0-1.1-.9-2-2-2s-2 .9-2 2H8c0-2.21 1.79-4 4-4s4 1.79 4 4c0 .88-.36 1.68-.93 2.25z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></a><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" type=\\"button\\" id=\\"header--button-registryInfo\\" title=\\"Registry Information\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 15h-2v-6h2v6zm0-8h-2V7h2v2z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></button><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" type=\\"button\\" id=\\"header--button-account\\" aria-owns=\\"sidebar-menu\\" aria-haspopup=\\"true\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm0 3c1.66 0 3 1.34 3 3s-1.34 3-3 3-3-1.34-3-3 1.34-3 3-3zm0 14.2c-2.5 0-4.71-1.28-6-3.22.03-1.99 4-3.08 6-3.08 1.99 0 5.97 1.09 6 3.08-1.29 1.94-3.5 3.22-6 3.22z\\"></path><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></button></div></div></header>"`;

exports[`<Header /> component with logged out state should load the component in logged out state 1`] = `"<header class=\\"MuiPaper-root-10 MuiPaper-elevation4-16 MuiAppBar-root-1 MuiAppBar-positionStatic-5 MuiAppBar-colorPrimary-8 css-6njnwn e1ctrp120\\"><div class=\\"MuiToolbar-root-37 MuiToolbar-regular-39 MuiToolbar-gutters-38 css-ioebmw e1ctrp121\\"><a href=\\"{registryUrl}/#/\\"><div class=\\"css-guljh6 e18wxr160\\"></div></a><div><a href=\\"https://verdaccio.org/docs/en/installation\\" target=\\"_blank\\" tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" role=\\"button\\" title=\\"Documentation\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 17h-2v-2h2v2zm2.07-7.75l-.9.92C13.45 12.9 13 13.5 13 15h-2v-.5c0-1.1.45-2.1 1.17-2.83l1.24-1.26c.37-.36.59-.86.59-1.41 0-1.1-.9-2-2-2s-2 .9-2 2H8c0-2.21 1.79-4 4-4s4 1.79 4 4c0 .88-.36 1.68-.93 2.25z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></a><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" type=\\"button\\" id=\\"header--button-registryInfo\\" title=\\"Registry Information\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 15h-2v-6h2v6zm0-8h-2V7h2v2z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></button><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiButton-root-108 MuiButton-text-110 MuiButton-flat-113 MuiButton-colorInherit-129\\" type=\\"button\\" id=\\"header--button-login\\"><span class=\\"MuiButton-label-109\\">Login</span><span class=\\"MuiTouchRipple-root-66\\"></span></button></div></div></header>"`;
exports[`<Header /> component with logged out state should load the component in logged out state 1`] = `"<header class=\\"MuiPaper-root-10 MuiPaper-elevation4-16 MuiAppBar-root-1 MuiAppBar-positionStatic-5 MuiAppBar-colorPrimary-8 css-6njnwn e1ctrp120\\"><div class=\\"MuiToolbar-root-37 MuiToolbar-regular-39 MuiToolbar-gutters-38 css-ioebmw e1ctrp121\\"><a href=\\"http://localhost/#/\\"><div class=\\"css-guljh6 e18wxr160\\"></div></a><div><a href=\\"https://verdaccio.org/docs/en/installation\\" target=\\"_blank\\" tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" role=\\"button\\" title=\\"Documentation\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 17h-2v-2h2v2zm2.07-7.75l-.9.92C13.45 12.9 13 13.5 13 15h-2v-.5c0-1.1.45-2.1 1.17-2.83l1.24-1.26c.37-.36.59-.86.59-1.41 0-1.1-.9-2-2-2s-2 .9-2 2H8c0-2.21 1.79-4 4-4s4 1.79 4 4c0 .88-.36 1.68-.93 2.25z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></a><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiIconButton-root-48 MuiIconButton-colorInherit-49\\" type=\\"button\\" id=\\"header--button-registryInfo\\" title=\\"Registry Information\\"><span class=\\"MuiIconButton-label-53\\"><svg class=\\"MuiSvgIcon-root-57\\" focusable=\\"false\\" viewBox=\\"0 0 24 24\\" aria-hidden=\\"true\\" role=\\"presentation\\"><path fill=\\"none\\" d=\\"M0 0h24v24H0z\\"></path><path d=\\"M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 15h-2v-6h2v6zm0-8h-2V7h2v2z\\"></path></svg></span><span class=\\"MuiTouchRipple-root-66\\"></span></button><button tabindex=\\"0\\" class=\\"MuiButtonBase-root-54 MuiButton-root-108 MuiButton-text-110 MuiButton-flat-113 MuiButton-colorInherit-129\\" type=\\"button\\" id=\\"header--button-login\\"><span class=\\"MuiButton-label-109\\">Login</span><span class=\\"MuiTouchRipple-root-66\\"></span></button></div></div></header>"`;

0 comments on commit 5b34dc8

Please sign in to comment.