-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate s3 subfolders (key prefix for different packages) #313
Conversation
Remove packagename as key for s3 objects Add package path from custom storage of packages
remove the duplications in trailing slash on paths
this folder is used per convention for minio or localstack for database
this is to access the packages and their store key
🚀🙏 |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 65.17% 70.62% +5.45%
==========================================
Files 26 27 +1
Lines 1407 1413 +6
Branches 205 206 +1
==========================================
+ Hits 917 998 +81
+ Misses 487 412 -75
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, test included 🥇 , still checking this but looks pretty promising, we should ignore some Docker files + config with the .npmignore
so are not bundle in the tarball.
aws-s3-storage plugin
Update the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impeccable 👌 thanks so much for taking care of this
* test: createPackage with s3 mock * feat: Add Custom Storage Remove packagename as key for s3 objects Add package path from custom storage of packages * test: Add number of assertions to tests * refactor: trailing slash function remove the duplications in trailing slash on paths * chore: add data to gitignore this folder is used per convention for minio or localstack for database * fix: replace s3config with whole config this is to access the packages and their store key * Add readme section * fix: jest registry in yarn.lock * Upgrade: aws-sdk aws-s3-storage plugin * fix: set minio endpoint in config.yaml * fix: Remove registry.env file from repo Update the README * Fix: aws secret access key example in README * Add npmignore
…r different packages) (#313) * test: createPackage with s3 mock * feat: Add Custom Storage Remove packagename as key for s3 objects Add package path from custom storage of packages * test: Add number of assertions to tests * refactor: trailing slash function remove the duplications in trailing slash on paths * chore: add data to gitignore this folder is used per convention for minio or localstack for database * fix: replace s3config with whole config this is to access the packages and their store key * Add readme section * fix: jest registry in yarn.lock * Upgrade: aws-sdk aws-s3-storage plugin * fix: set minio endpoint in config.yaml * fix: Remove registry.env file from repo Update the README * Fix: aws secret access key example in README * Add npmignore
my pleasure. This was a really good foundation for future work together. |
https://github.com/verdaccio/verdaccio/blob/master/CONTRIBUTING.md#git-commit-guidelines
Type: Feature
Scope: aws-s3-storage plugin
The following has been addressed in the PR:
Description:
the s3 plugin adds all packages (proxy or none proxy) flat out in the root of the s3 bucket. This PR resolves that issue by using the storage key in the packages section of the config file as a folder in s3 bucket