Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable eslint curly #308

Merged
merged 1 commit into from
Dec 28, 2019
Merged

feat: enable eslint curly #308

merged 1 commit into from
Dec 28, 2019

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Dec 27, 2019

Type: feat
Scope: eslint

The following has been addressed in the PR:

  • There is a related issue? No
  • Unit or Functional tests are included in the PR No

Description:

this is disabled by prettier default config and we want it enabled it

I notice that #289 allows curly and our config should forbid such practice.

this is disabled by prettier default config and we want it enabled it
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #308 into master will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   65.33%   65.31%   -0.03%     
==========================================
  Files          26       26              
  Lines        1402     1404       +2     
  Branches      202      205       +3     
==========================================
+ Hits          916      917       +1     
  Misses        484      484              
- Partials        2        3       +1
Flag Coverage Δ
#core 88.18% <ø> (ø) ⬆️
#plugins 58.3% <40%> (-0.02%) ⬇️
Impacted Files Coverage Δ
plugins/aws-s3-storage/src/s3PackageManager.ts 0.63% <0%> (-0.01%) ⬇️
plugins/htpasswd/src/utils.ts 98.5% <100%> (+0.02%) ⬆️
plugins/memory/src/memory-handler.ts 87.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617e5da...0d25a2c. Read the comment docs.

@juanpicado
Copy link
Member Author

Intersting ...

Successfully applied Snyk patches

lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2ftesting-utilities 372ms
lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2fbabel-preset 391ms
lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2fcommons-api 522ms
lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2freadme 470ms
lerna http fetch PUT 409 https://registry.verdaccio.org/eslint-plugin-verdaccio 454ms
lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2feslint-config 457ms
lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2ffile-locking 500ms
lerna http fetch PUT 409 https://registry.verdaccio.org/@verdaccio%2fstreams 493ms
lerna http fetch PUT 409 https://registry.verdaccio.org/verdaccio-aws-s3-storage 612ms
lerna http fetch PUT 409 https://registry.verdaccio.org/verdaccio-audit 866ms
lerna http fetch PUT 409 https://registry.verdaccio.org/verdaccio-htpasswd 861ms
lerna http fetch GET 200 https://registry.verdaccio.org/verdaccio-htpasswd?write=true 423ms
lerna ERR! EPUBLISHCONFLICT Cannot publish verdaccio-htpasswd@undefined over existing version.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command

@juanpicado juanpicado merged commit 91acb12 into master Dec 28, 2019
@juanpicado juanpicado deleted the feat-curly branch December 28, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants