Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verdaccio-google-cloud): catch missing Secret on first run #247

Merged
merged 1 commit into from
Dec 28, 2019

Conversation

donbowman
Copy link
Contributor

in getSecret, if /Secret does not exist, we had an async
error uncaught. Catch it explicitly so that the Secret
will get created.

Type:
Scope:

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #247 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   65.45%   65.31%   -0.14%     
==========================================
  Files          26       26              
  Lines        1401     1404       +3     
  Branches      201      201              
==========================================
  Hits          917      917              
- Misses        482      485       +3     
  Partials        2        2
Flag Coverage Δ
#core 88.18% <ø> (ø) ⬆️
#plugins 58.3% <0%> (-0.14%) ⬇️
Impacted Files Coverage Δ
plugins/google-cloud/src/data-storage.ts 78.65% <0%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d3c63...fabd384. Read the comment docs.

in getSecret, if /Secret does not exist, we had an async
error uncaught. Catch it explicitly so that the Secret
will get created.
@donbowman donbowman changed the title fix(google-cloud): catch missing Secret on first run fix(verdaccio-google-cloud): catch missing Secret on first run Nov 14, 2019
@donbowman
Copy link
Contributor Author

I'm not sure what i'm supposed to do, the failure is:

lerna http fetch PUT 401 https://registry.verdaccio.org/verdaccio-google-cloud 593ms
lerna ERR! E401 authorization required to publish package verdaccio-google-cloud

but i'm unclear on why a job run on my behalf would have permissions to publish or where they would come from.

Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution to verdaccio.

@juanpicado juanpicado merged commit 7742eea into verdaccio:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants