fix: fixes for storage plugin types per code review (#59)

verdaccio · Jul 25, 2019 · 04fccb8 · 04fccb8
1 parent b032e8c
commit 04fccb8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/types/index.d.ts b/core/types/index.d.ts
@@ -339,7 +339,7 @@ type StringValue = string | void | null;
 		max_body_size?: string;
 		notifications?: Notifications;
 		middlewares?: any;
-		storage_filters?: any;
+		filters?: any;
 		checkSecretKey(token: string): string;
 		getMatchedPackagesSpec(storage: string): PackageAccess | void;
 		[key: string]: any;
@@ -442,6 +442,6 @@ type StringValue = string | void | null;
 	}
 
 	interface IPluginStorageFilter<T> extends IPlugin<T> {
-		filter_metadata(packageInfo: Package, cb: Callback): void;
+		filter_metadata(packageInfo: Package): Promise<Package>;
 	}
 }
diff --git a/core/types/src/flow/types.js b/core/types/src/flow/types.js
@@ -332,7 +332,7 @@ declare interface verdaccio$Config {
   max_body_size?: string;
   notifications?: verdaccio$Notifications;
   middlewares?: any;
-  storage_filters?: any;
+  filters?: any;
   checkSecretKey(token: string): string;
   getMatchedPackagesSpec(storage: string): verdaccio$PackageAccess | void;
   [key: string]: any;
@@ -409,7 +409,7 @@ declare interface verdaccio$IBasicAuth {
 
 declare interface verdaccio$IPlugin {
   version?: string;
-  close(): void;
+  // Optional: close(): void;
 }
 
 declare type verdaccio$PluginOptions = {
@@ -431,7 +431,7 @@ declare interface verdaccio$IPluginMiddleware extends verdaccio$IPlugin {
 }
 
 declare interface verdaccio$IPluginStorageFilter extends verdaccio$IPlugin {
-  filter_metadata(packageInfo: verdaccio$Package, cb: verdaccio$Callback): void;
+  filter_metadata(packageInfo: verdaccio$Package): Promise<verdaccio$Package>;
 }
 
 declare module "@verdaccio/local-storage" {