[next] Add handling for not found routes with i18n #5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
previously approved these changes
Oct 22, 2020
timneutkens
approved these changes
Oct 23, 2020
styfle
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to handle the
notFoundRoutesadded to theprerender-manifestwhich tells us which SSG routes were not generated at build time. This allows users to not generate versions of a non-dynamic SSG page for all locales and only the relevant ones for that page.The added tests in this PR will currently fail until vercel/next.js#18119 is landed on canary
x-ref: vercel/next.js#17370