fix(turbopack): Update app-renderer #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 6db060b
Click to view full benchmark
|
jridgewell
approved these changes
Mar 7, 2023
jridgewell
added
the
pr: automerge
sokra
reviewed
Mar 7, 2023
| return __entry_css_files__; | ||
| } | ||
| return new Proxy({}, proxyMethodsForModule(name as string, css)); | ||
| const [file, name] = (key as string).split("#"); |
There was a problem hiding this comment.
The file could potentially contain # and the name could also potentially contain #. This is pretty unsafe to join with #.
Can't we encode all information into the JSON instead of joining with #.
There was a problem hiding this comment.
I'm not sure what's a Next.js detail and what's a Turbopack detail. Is the name really supposed to be JSON, or is that a hack that we did? If we instead did an rsplit here, would that fix our hack without changing Next's behavior?
There was a problem hiding this comment.
The JSON.parse is a hack inside Turbopack. That # was from React's upstream change: facebook/react#26300 and we had to encode it that way.
name can never contain # because it's the module's export name (export const foo) or *. But not sure if a filepath can contain the # symbol or not, I think it's unlikely.
There was a problem hiding this comment.
The react change changes from filename and name as separate entities to a single id. next.js creates the file#name encoding here: https://github.com/vercel/next.js/blob/7e933a094c3f7a17ae085396633ad6525ccfb590/packages/next/src/build/webpack/loaders/next-flight-loader/module-proxy.ts#L168
We could also choose a different encoding, e. g. JSON.
folders can contain #, unlikely but some people do that /home/blah/#repos which already led to some trouble because we had some special behavior for fragments in webpack.
even export names will soon be able to support any string. There is a proposal for that.
But anyway...
There was a problem hiding this comment.
I changed this to use an rsplit.
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 7, 2023
Reverts #46861. This requires vercel/turborepo#4102 to be released and bindings to be updated first. ~Also depends on #46896 to be merged first, and conflicts to be resolved.~
Benchmark for 87275b3
Click to view full benchmark
|
Benchmark for 5c47b33
Click to view full benchmark
|
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
### Description This PR mirrors some related manifest changes in Next.js: #46881. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Justin Ridgewell <[email protected]>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
### Description This PR mirrors some related manifest changes in Next.js: #46881. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Justin Ridgewell <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This PR mirrors some related manifest changes in Next.js: #46881. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Justin Ridgewell <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This PR mirrors some related manifest changes in Next.js: #46881. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Justin Ridgewell <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This PR mirrors some related manifest changes in Next.js: #46881. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Justin Ridgewell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mirrors some related manifest changes in Next.js: vercel/next.js#46881.
Testing Instructions