Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change from tui-term used in turborepo-vt100 breaks the building procedure when turborepo-lib used as a git dependency #9021

Closed
1 task done
wadwings opened this issue Aug 16, 2024 · 1 comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage

Comments

@wadwings
Copy link
Contributor

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/wadwings/use-turbo-as-crate

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

2.0.14

Describe the Bug

turborepo-lib fail to build when used as git crate, due to the breaking change and misused version from tui-term.

manually lock the version of tui-term would fix this problem.

Expected Behavior

build without error.

To Reproduce

» cargo run
Compiling itertools v0.13.0
Compiling compact_str v0.8.0
Compiling unicode-truncate v1.1.0
Compiling ratatui v0.28.0
Compiling ratatui v0.26.3
Compiling tui-term v0.1.13
Compiling turborepo-vt100 v0.15.2 (https://github.com/vercel/turborepo.git#219c1140)
error[E0053]: method apply has an incompatible type for trait
--> /Users/wings/.cargo/git/checkouts/turborepo-f0841dd6c30a2f0c/219c114/crates/turborepo-vt100/src/tui_term.rs:40:27
|
40 | fn apply(&self, cell: &mut ratatui::buffer::Cell) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| expected Cell, found ratatui::buffer::Cell
| help: change the parameter type to match the trait: &mut ratatui::buffer::cell::Cell
|
= note: expected signature fn(&cell::Cell, &mut ratatui::buffer::cell::Cell)
found signature fn(&cell::Cell, &mut ratatui::buffer::Cell)

For more information about this error, try rustc --explain E0053.
error: could not compile turborepo-vt100 (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Additional context

No response

@wadwings wadwings added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Aug 16, 2024
@wadwings
Copy link
Contributor Author

lock the tui-term version would easily fix the problem, please see through #9022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

No branches or pull requests

2 participants