Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability of turbo gen #8483

Open
1 task done
ghdtjgus76 opened this issue Jun 14, 2024 · 2 comments
Open
1 task done

Security vulnerability of turbo gen #8483

ghdtjgus76 opened this issue Jun 14, 2024 · 2 comments
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage

Comments

@ghdtjgus76
Copy link
Contributor

ghdtjgus76 commented Jun 14, 2024

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

.

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

[email protected]

Describe the Bug

turbo/gen relies on proxy-agent, which in turn depends on pac-proxy-agent and socks-proxy-agent.
pac-proxy-agent uses pac-resolver and socks-proxy-agent.
socks-proxy-agent depends on the socks package, and both pac-resolver and socks depend on the ip package.
As indicated in the reference below, using the ip package can lead to security issues, which will be flagged as vulnerabilities in the repository's security tab.

GHSA-78xj-cgh5-2h22
indutny/node-ip#150

Expected Behavior

It seems that the ip package is currently not actively maintained.
To address such issues, it might be beneficial to consider modifying the package.

To Reproduce

.

Additional context

No response

@ghdtjgus76 ghdtjgus76 added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Jun 14, 2024
@devjiwonchoi
Copy link
Member

@nguyenlam123
Copy link

Hello all! 👋

I'm wondering if there is patch planned for this for version 1 of turbo?

Thanks in advance! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

No branches or pull requests

4 participants