Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Support for node-adodb #736

Closed
chrissantamaria opened this issue Jul 8, 2019 · 5 comments
Closed

Support for node-adodb #736

chrissantamaria opened this issue Jul 8, 2019 · 5 comments
Labels

Comments

@chrissantamaria
Copy link

I currently use pkg in production with node-adodb being one of my main packages used in my application. Due to the way it performs database queries, it relies on one of its lib files adodb.js being accessible from a spawned CScript process which pkg prevents due to its bundling behavior.

This is a known issue and the current solution is to manually copy the file to the execution directory and point node-adodb to it. This works fine for me, but I would prefer for the Node process to be able to either create this file at runtime if it's not present or prevent needing it in the directory altogether.

I see the dictionary directory in pkg filled with what I suspect to be patches for some packages, though there's no documentation I could find on them. Is there any way a similar patch could be made for node-adodb / where could I find resources to create a patch myself?

@chrissantamaria
Copy link
Author

Found a slightly better solution - I'm now able to copy the file directly from node_modules to the execution directory. I was unable to do this previously because of a ENOENT error when running fs.copyFileSync but a temporary solution in #420 seems to work for now.

That being said, proper support for node-adodb and, more importantly, documentation for package patches would be greatly appreciated.

@albertot-dev
Copy link

Hi @chrissantamaria i have same problem, but i dont understand how you resolve. Can you show me the code?

@chrissantamaria
Copy link
Author

Sure! Here's a demo repo to show how I've handled this situation in the past: https://github.com/chrissantamaria/pkg-node-adodb

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

@github-actions github-actions bot added the Stale label Apr 1, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This issue is now closed due to inactivity, you can of course reopen or reference this issue if you see fit.

@github-actions github-actions bot closed this as completed Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants