Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exports / imports pattern trailers support #266

Open
guybedford opened this issue Feb 9, 2022 · 1 comment · May be fixed by #361
Open

Add exports / imports pattern trailers support #266

guybedford opened this issue Feb 9, 2022 · 1 comment · May be fixed by #361
Labels
enhancement New feature or request

Comments

@guybedford
Copy link
Contributor

Mostly, the resolve implementation here is in line with the latest Node.js modules resolution, except for support for pattern trailers which was a late addition in nodejs/node#39635.

As packages start to ship this feature (which will be recommended in Node.js soon), these resolutions will fail to be resolved in NFT.

Posting as a tracking issue before that happens. It should be relatively straightforward and I'd be happy to work on a PR here if there is interest.
@styfle styfle added the enhancement New feature or request label Feb 9, 2022
@styfle
Copy link
Member

styfle commented Feb 9, 2022 •
edited
Loading

Sounds good to me! If Node.js supports it, we want nft to support it too.

Feel free to submit a PR with a test and I'll take a look! 👍

@jedwards1211 jedwards1211 linked a pull request Sep 9, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support pattern trailers jedwards1211/vercel-nft
2 participants
@styfle @guybedford