Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add wait for the error page navigation #72760

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 13, 2024

When the export is invalid and fails the page build, since there's a navigation to /_error route, which waits for the /_error to be built and loaded, then we verify if the error dialog to pop up

x-ref: https://github.com/vercel/next.js/actions/runs/11816385255/job/32919640556?pr=72586

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Nov 13, 2024
Copy link
Member Author

huozhi commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @huozhi and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Nov 13, 2024

Tests Passed

@huozhi huozhi marked this pull request as ready for review November 13, 2024 14:38
@huozhi huozhi requested a review from gaojude November 13, 2024 14:38
@huozhi huozhi merged commit d5e2701 into canary Nov 13, 2024
106 of 110 checks passed
@huozhi huozhi deleted the 11-13-test_fix_wait_invalid_export branch November 13, 2024 16:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants