Fix unhandled rejection in proxy-request #72530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremieDoctrine
changed the title
|
@wyattjoh (sorry for the random ping but you were the last one committing on this file) Is there any chance you can help me in getting this merged 🙇 I'm quite confident this is a real issue and I'm sure people will encounter it when upgrading to Next.js 15 as we did 😬 |
wyattjoh
approved these changes
Nov 18, 2024
|
Thanks a lot ! |
wyattjoh
added a commit
that referenced
this pull request
Nov 28, 2024
Trying to fix : #72522 ### What? The finally method actually creates a new promise. You have to listen to this new promise instead of the original one or you might end up with unhandled rejection. Taken from the documentation : > The finally() method of [Promise](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) instances schedules a function to be called when the promise is settled (either fulfilled or rejected). It immediately returns another [Promise](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) object, allowing you to [chain](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises#chaining) calls to other promise methods. ### Why? see : #72522 ### How? Fixes : #72522 Co-authored-by: Wyatt Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix : #72522
What?
The finally method actually creates a new promise. You have to listen to this new promise instead of the original one or you might end up with unhandled rejection.
Taken from the documentation :
Why?
see : #72522
How?
Fixes : #72522