Migrate HeadManager to use React.createContext #5945
Closed
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
timneutkens
reviewed
Dec 25, 2018
| return <Container> | ||
| <Component {...pageProps} url={url} /> | ||
| </Container> | ||
| return <HeadManagerContext.Provider value={headManager}> |
There was a problem hiding this comment.
This should be added in packages/next/client/index.js, as users override _app.js with their own render method.
timneutkens
reviewed
Dec 25, 2018
| @@ -2,10 +2,10 @@ import React from 'react' | |||
| import PropTypes from 'prop-types' | |||
| import sideEffect from './side-effect' | |||
|
|
|||
| export const HeadManagerContext = React.createContext() | |||
There was a problem hiding this comment.
I think this should be moved to a separate file so that we're 100% sure it will only bundle this line instead of always bundling the <Head> next/head component even when it's not being used.
|
I can pick this up if you don't have time for it @chrislloyd 😄 |
|
Feel free to @alexandernanberg 🙏 Thanks! |
|
Closing this PR in favor of #6038 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more focused PR from #5935 and responding to #5716. Converts HeadManager to use the new React.createContext api.