Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the experimental serverActions flag #57145

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

gnoff
Copy link
Contributor

@gnoff gnoff commented Oct 20, 2023

Remove the experimental serverActions flag

@gnoff gnoff requested review from ismaelrumzan and StephDietz and removed request for a team October 20, 2023 18:16
@vercel-spaces
Copy link

vercel-spaces bot commented Oct 20, 2023

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @styfle, @huozhi:

packages/next/src/server/config.ts

@gnoff gnoff force-pushed the remove-server-actions-option branch from 3a80221 to 586009a Compare October 20, 2023 18:17
@ijjk
Copy link
Member

ijjk commented Oct 20, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 20, 2023

Stats from current PR

Default Build
General
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
buildDuration 10.3s 10.4s ⚠️ +103ms
buildDurationCached 6.1s 6.1s N/A
nodeModulesSize 174 MB 174 MB N/A
nextStartRea..uration (ms) 498ms 495ms N/A
Client Bundles (main, webpack)
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
199-HASH.js gzip 27.6 kB 27.6 kB
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
index.html gzip 527 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 525 B
Overall change 525 B 525 B
Edge SSR bundle Size
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
edge-ssr.js gzip 93.9 kB 93.9 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary gnoff/next.js remove-server-actions-option Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: a12060a

@gnoff gnoff changed the title Remove server actions option Remove the experimental serverActions flag Oct 20, 2023
@gnoff gnoff changed the title Remove the experimental serverActions flag Remove the experimental serverActions flag Oct 20, 2023
feedthejim
feedthejim previously approved these changes Oct 20, 2023
@kodiakhq kodiakhq bot merged commit 5528cc6 into vercel:canary Oct 20, 2023
52 of 57 checks passed
@leerob
Copy link
Member

leerob commented Oct 20, 2023

LFG

@gnoff gnoff deleted the remove-server-actions-option branch October 20, 2023 21:19
@leonaves
Copy link

leonaves commented Oct 22, 2023

What are you absolute cowboys doing just publishing this to your docs when this none of this is in the stable releases yet. Do you enjoy wasting people's time?

@leerob
Copy link
Member

leerob commented Oct 22, 2023

@leonaves some React docs have already landed and more will be landing this week. Note that the canary React channel is stable for frameworks to adopt.

@leonaves
Copy link

I mean someone has already reverted this change in the live docs since yesterday so you obviously know you messed up.

@leonaves
Copy link

leonaves commented Oct 23, 2023

Also, React's docs say clearly the new hooks are only available in canary, whereas running:

npx create-next-app@latest

Installs react-dom 18.2.14 which doesn't have support for the new hooks. So while you're right you're able to adopt it, you don't install it by default or anywhere in the docs mention that you have to update your dependencies to canary to use it? How can you think that's okay?

@leerob
Copy link
Member

leerob commented Oct 23, 2023

I mean someone has already reverted this change in the live docs since yesterday so you obviously know you messed up.

It was not clear to me that you meant that docs for this were live already, which then prompted me to go look, and you were correct - those slipped out. While they're merged into main here, they shouldn't have been live yet, until our release Thursday. Sorry about that.

(More specifically, docs being merged into this repo shouldn't mean they go live immediately. It should be part of a release being tagged)

Edit: Also -> https://twitter.com/reactjs/status/1716573234160967762

ijjk pushed a commit that referenced this pull request Oct 24, 2023
Since this is now enabled as of
#57145
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants